feat: add init command #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/commands/prompt/index.ts
Outdated
| describe: 'Verbose output', | ||
| }), | ||
| handler: (args) => run(args._.join(' '), args), | ||
| handler: (args) => { |
Member
There was a problem hiding this comment.
[high] Instead of trying to handle it here, you should modify bin.ts to include init command as well.
src/commands/init/index.ts
Outdated
| }, | ||
| { | ||
| type: 'confirm', | ||
| message: 'Do you already have OpenAI API key?', |
Member
There was a problem hiding this comment.
You are asking about OpenAI api key, what about case when user wanted to provide only Perplexity key?
src/commands/init/index.ts
Outdated
| { | ||
| type: (prev) => (prev ? 'password' : null), | ||
| name: 'apiKey', | ||
| message: 'Paste your OpenAI key here:', |
mdjastrzebski
requested changes
Feb 21, 2024
Member
mdjastrzebski
left a comment
mdjastrzebski
left a comment
There was a problem hiding this comment.
Looks promising. I've noticed some issue to be handled:
- Prompt always ask for OpenAI key (message is fixed to OpenAI)
initcommand should be configured onbin.tslevel, not insideprompt.ts- We currently have
~.aircfile which is a JSON file but without.jsonextension editors might not recognize it as such.
In order to mitigate it for early adopters, let's a a simple code that runs early and moves ~.airc.json file to ~/.airc.json
const LEGACY_CONFIG_FILE = `.airc`;
const CONFIG_FILE = `.airc.json`;
mdjastrzebski
approved these changes
Feb 22, 2024
Member
mdjastrzebski
left a comment
mdjastrzebski
left a comment
There was a problem hiding this comment.
Looks good!
Pls resolve comments before merging @Q1w1N.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new init command
Summary
init command can be triggered manually, and it triggers automatically if prompt i run withour config file.
Test plan
Run through all use cases.